docs: v0.14 update for both internal and external#1990
Open
Mirko-von-Leipzig wants to merge 2 commits intomainfrom
Open
docs: v0.14 update for both internal and external#1990Mirko-von-Leipzig wants to merge 2 commits intomainfrom
Mirko-von-Leipzig wants to merge 2 commits intomainfrom
Conversation
Mirko-von-Leipzig
added
the
no changelog
Mirko-von-Leipzig
force-pushed
the
mirko/docs
branch
from
b11c116 to
7513d70
Compare
Mirko-von-Leipzig
added
the
documentation
bobbinth
approved these changes
Apr 23, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left a few small comments inline.
Contributor
There was a problem hiding this comment.
I think this is missing a couple of links:
- RPC sends incoming transactions to the validator for validation.
- I would maybe add an arrow going from the block prover back to the store and make it clear that we are sending a block proof back.
Comment on lines
48
to
+49
| Transactions are placed in a mempool and are periodically sampled to form batches of transactions. These batches are | ||
| proved, and then periodically aggregated into a block. This block is then proved and committed to the store. | ||
| proved, and then periodically aggregated into a block. This proposed block is then submitted to the store. |
Contributor
There was a problem hiding this comment.
Is "proposed block" the right phrasing here? Maybe it should be "constructed block" or "composed block".
Also, I think this is missing the part that the block producer fist sends the block for a signature to the validator - and then, only once the validator signs the block, it is sent to the store.
Comment on lines
+18
to
+20
| Proven batches are selected from the mempool periodically to form the next block. The block is then built and submitted | ||
| to the store, which ensures it gets signed by the validator before it is committed. At this point all transactions and | ||
| batches in the block are marked in the mempool as committed. |
Contributor
There was a problem hiding this comment.
I believe the block producer -> store flow is a bit inverted here. Specifically:
- The block producer sends the block to the validator and gets a signature back.
- Then, once the block is signed, the block producer sends it to the store.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial doc pass for v0.14.
I've updated the diagrams, and also removed some sections which will always be changing because they include overly technical details e.g. there is no need to list specific error codes in our internal documentation imo.
I'll do another pass, but opening for review so long.
Closes #1619